Hi,
Recently I have been working with the InteractiveModule from Draft: New Module: InteractivePropagationModule by gkunkler · Pull Request #53 · allpix-squared/all…
First of all, many thanks to the creator of this module! I am using it for an investigation and it works very nice.
I think I found a bug regarding the propagating charges and I was wondering if this could be changed:
-
In line 907 of InteractivePropagationModule.cpp Draft: New Module: InteractivePropagationModule by gkunkler · Pull Request #53 · allpix-squared/allpix-squared · GitHub, charge is a reference. This causes the first charge group from propagating_charges to be overwritten by the propagating_charges[i] on line 1052. This will result in the first charge group being identical to the final charge group. In my case, since I had charge_per_step = 100, it resulted in the first group having the same amount of ‘left-over’ charge carriers as the last group.
A possible fix could be to leave the reference out (no &). I tested this with a local repo and this indeed fixed the issue.
Somehow Github did not allow me to post a review / comment in the pull request, so that is why I am informing you via this forum. I hope the issue is clear and if you have any questions, feel free to reach out!
Kind regards,
Jurgen